-
Notifications
You must be signed in to change notification settings - Fork 29
Results for Token throughput based benchmarks #1071
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: submission-v6.0
Are you sure you want to change the base?
Conversation
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
for updated MacOS CI
freedomtan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
|
|
I've added the units next to the result values. As for the 🛈 icon, I was going to make multiple versions and see which one looked best, but then I noticed that the 'make the icon a clickable button and put the info there' idea has already been implemented and approved for the config screen as per #1028. So I opted to replicate the same UI in the result screen. I also edited the history screen to have both QPS average for non token benchmarks and TPS average for token benchmarks. In addition to adding T/sec or Q/sec for each benchmark in the table below the summary. |
|
|
please add the time to first token to the "Result details" |






No description provided.