[FEAT] [UI] Internalize igz-controls from dashboard-react-controls#3713
[FEAT] [UI] Internalize igz-controls from dashboard-react-controls#3713arturrybalskyy-dev wants to merge 3 commits into
Conversation
Taras-Hlukhovetskyi
left a comment
Taras-Hlukhovetskyi
left a comment
There was a problem hiding this comment.
Also it would be nice if you will refactor imports to get reed of this alias. Element move to element, components to common, utils to utils and so on.
And please check if there is no new commits was added to DRC since you moved files
Thank you
| ), | ||
| 'igz-controls/index.css': path.resolve(__dirname, 'src/igz-controls/index.scss'), | ||
| 'igz-controls': path.resolve(__dirname, 'src/igz-controls'), | ||
| '@igz-controls': path.resolve(__dirname, 'src/igz-controls/nextGenComponents'), |
There was a problem hiding this comment.
duplication '@igz-controls': path.resolve(__dirname, 'src/igz-controls/nextGenComponents'), and 'igz-controls/nextGenComponents': path.resolve(
| { find: 'igz-controls/nextGenComponents', replacement: path.resolve(__dirname, 'src/igz-controls/nextGenComponents/index.ts') }, | ||
| { find: 'igz-controls/index.css', replacement: path.resolve(__dirname, 'src/igz-controls/index.scss') }, | ||
| { find: 'igz-controls', replacement: path.resolve(__dirname, 'src/igz-controls') }, | ||
| { find: '@igz-controls', replacement: path.resolve(__dirname, 'src/igz-controls/nextGenComponents') }, |
There was a problem hiding this comment.
duplications src/igz-controls/nextGenComponents
|
|
||
| export default [ | ||
| { ignores: ['dist'] }, | ||
| { ignores: ['dist', 'src/igz-controls/nextGenComponents/**'] }, |
There was a problem hiding this comment.
why nextGenComponents are exlcluded? Pls add separete rules for typescript (qunique) and parser as we have in DRC
| @@ -23,7 +23,8 @@ module.exports = { | |||
| darkMode: ['class'], | |||
| content: [ | |||
| './src/nextGenComponents/**/*.{js,jsx,ts,tsx}', | |||
| './node_modules/iguazio.dashboard-react-controls/dist/nextGenComponents/**/*.{js,mjs}' | |||
| './src/igz-controls/nextGenComponents/**/*.{js,jsx,ts,tsx}', | |||
| './src/layout/**/*.{js,jsx,ts,tsx}' | |||
There was a problem hiding this comment.
why do we need this path './src/layout/**/*.{js,jsx,ts,tsx}' ?
|
@arturrybalskyy-dev pls also get letest files from DRC and add description the last coment on DRC that we fetched files from so we will update it again before the merge if nedded |
2 participants
📝 Description
Moves all used
dashboard-react-controls(DRC) components, hooks, utils, constants, types, styles, and images intoui/src/igz-controls/and redirects the existingigz-controlsVite alias fromnode_modulesto the local path.This removes the
iguazio.dashboard-react-controlsnpm dependency entirely. All 391 source files that import fromigz-controls/...require zero changes - the alias preservation strategy ensures full backwards compatibility.🛠️ Changes Made
ui/src/igz-controls/- full local copy of all used DRC entities (components, hooks, utils, constants, types, scss, fonts, images, nextGenComponents)vite.config.mjsandvitest.config.mjs- redirectedigz-controlsalias fromnode_modules/iguazio.dashboard-react-controls/disttosrc/igz-controls/jsconfig.jsonandtsconfig.json- added matching path mappings for IDE resolutionpackage.json- removediguazio.dashboard-react-controlsdependency; removednli/nuiscripts that installed/updated DRCeslint.config.mjs- addedsrc/igz-controls/nextGenComponents/**to ignores (TypeScript files requiring TS-aware parser).github/workflows/ci.yaml- updated error hint to referenceui/src/igz-controls/instead of the removed npm packagesrc/igz-controls/index.scss—-replaces the formerdist/index.cssglobal stylesheet bundle✅ Checklist
🔗 References
🚨 Potentially Breaking Changes
Includes DRC change
🔍 Additional Notes
ChipFormcomponent andproxyServerConfigutil were intentionally excluded per task requirement ("Do not move unused entities")