Skip to content

Allow children for Dialog.Button #138

Description

@nephix

Ask your Question

Does it make sense to extend <Dialog.Button /> to render children? My use case is that I e.g. display a confirmation dialog. Once the user presses "Ok" I want to disable the button (already possible) and display a loading indicator:

<Dialog.Button disabled={loading}>
   {loading && <LoadingIndicator />}
   <Text>Confirm</Text>
</Dialog.Button>

with the current implementation via label this is not possible.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    questionFurther information is requested

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions