Skip to content

fix: Tree conversion breaking when LC_NUMERIC not standard "C".#515

Merged
mmschlk merged 3 commits into
mainfrom
tree_conversion-fix
May 13, 2026
Merged

fix: Tree conversion breaking when LC_NUMERIC not standard "C".#515
mmschlk merged 3 commits into
mainfrom
tree_conversion-fix

Conversation

@Advueu963
Copy link
Copy Markdown
Collaborator

Motivation and Context

Fix Tree conversion problems due to LC_NUMERIC not set to standard C, but de_DE. As such the conversion library did not correctly parse the XGBoost/LightGBM model.

Public API Changes

  • No Public API changes
  • Yes, Public API changes (Details below)

How Has This Been Tested?

We have added new tests, to check that the conversion works correclty.

Checklist

  • The changes have been tested locally.
  • Documentation has been updated (if the public API or usage changes).
  • An entry has been added to CHANGELOG.md (if relevant for users).
  • The code follows the project's style guidelines.
  • I have considered the impact of these changes on the public API.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link
Copy Markdown
Owner

@mmschlk mmschlk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still do not like this hack here. Gotta think this through for v2 a bit better. But at least we now support germans. :D

@mmschlk mmschlk merged commit 4300f40 into main May 13, 2026
11 of 12 checks passed
@mmschlk mmschlk deleted the tree_conversion-fix branch May 13, 2026 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants