TEST: verify shell injection is blocked with branch name test-$(id)#32
Closed
jonathansantilli wants to merge 2 commits intoaction/E-1815from
Closed
TEST: verify shell injection is blocked with branch name test-$(id)#32jonathansantilli wants to merge 2 commits intoaction/E-1815from
jonathansantilli wants to merge 2 commits intoaction/E-1815from
Conversation
Collaborator
Author
Injection test result: PASSThe branch name
Closing this test PR. The fix is verified. |
5 tasks
Print REPO and BRANCH values so reviewers can verify that branch names containing shell metacharacters (e.g. test-$(id)) are treated as literal text and not executed. Ref: E-1815
Collaborator
Author
|
Injection test completed successfully. See PR #31 comment for evidence. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this tests
This PR exists solely to verify that the security fix on
action/E-1815works.The branch name is
test-$(id). If the injection vulnerability still existed,$(id)would execute as a shell command and the logs would show something likeuid=1001(runner).If the fix works, the logs should show the literal string
test-$(id)withoutexecuting anything.
Close this PR after verifying the logs. Do not merge.