revert: revert security fix PRs #31 and #33 to unblock deployments [E-1815]#35
Merged
jonathansantilli merged 3 commits intomainfrom Apr 8, 2026
Merged
revert: revert security fix PRs #31 and #33 to unblock deployments [E-1815]#35jonathansantilli merged 3 commits intomainfrom
jonathansantilli merged 3 commits intomainfrom
Conversation
The mobbdev CLI now prefixes its output with status messages like "[WebSocket Mode] Using WebSocket subscription..." before the URL. Extract just the https:// URL using grep. Ref: E-1815
|
Kirill89
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts PRs #31 and #33 to restore the original action code and unblock deployments.
The security fix (removing eval, using bash arrays) broke the autofixer CI test which uses
sedto replacenpx --yes mobbdev@latestwith a local build command containing an inline env var prefix (API_URL=...). This pattern is incompatible with bash arrays.The security fix will be re-applied with a different approach that is compatible with the test tooling.
Reverted commits
bf76c59— fix: use env command for array execution (fix: use env command for bash array execution [E-1815] #33)a12bce4— fix: prevent shell injection via eval (fix: prevent shell injection via eval in action.yml and review/action.yml [E-1815] #31)Ref: E-1815