Skip to content

Preserve request-stream ownership during server cleanup - #3540

Open
Kludex wants to merge 1 commit into
mainfrom
preserve-request-stream-ownership
Open

Kludex wants to merge 1 commit into
mainfrom
preserve-request-stream-ownership

Preserve request-stream ownership during server cleanup

1bdf987
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed Sep 18, 2026 in 17m 24s

Code review found 2 potential issues

Found 8 candidates, confirmed 2. See review comments for details.

Details

Severity Count
🔴 Important 0
🟡 Nit 0
🟣 Pre-existing 2
Severity File:Line Issue
🟣 Pre-existing src/mcp/server/streamable_http.py:0 Servers that call ctx.close_sse_stream() from a long-running handler can still kill a newer request's SSE stream after r
🟣 Pre-existing src/mcp/server/streamable_http.py:684 nit: AGENTS.md forbids 'except Exception:' outside top-level handlers. The restructured POST SSE branch (line 684) and s