Repository navigation
Fall back to an NTFS junction when the symlink escape test can't create a symlink - #3609
Merged
Merged
Claude / Claude Code Review
completed
Oct 1, 2026 in 3m 43s
Code review found 3 potential issues
Found 4 candidates, confirmed 3. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 2 |
| 🟣 Pre-existing | 1 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | tests/shared/test_path_security.py:151 |
nit: maintainers get an inline 'import _winapi' inside the except arm at tests/shared/test_path_security.py:151, which t |
| 🟡 Nit | tests/shared/test_path_security.py:149 |
nit: AGENTS.md says to avoid adding new coverage pragmas, and documents '# pragma: lax no cover' as for "lines covered o |
| 🟣 Pre-existing | tests/shared/test_path_security.py:155 |
Maintainers keep a test that pins SDK-authored error text via 'match="escapes base"' at tests/shared/test_path_security. |
Loading