Skip to content

Update fmi-ls-dae.xml - #690

Merged
t-sommer merged 3 commits into
modelica:mainfrom
elmir-nahodovic:patch-1
Sep 2, 2026
Merged

t-sommer merged 3 commits into
modelica:mainfrom
elmir-nahodovic:patch-1

Conversation

@elmir-nahodovic

Copy link
Copy Markdown
Contributor

@chrbertsch chrbertsch left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Do we have tooling to validate against the schema?

elmir-nahodovic added a commit to elmir-nahodovic/fmi-ls-dae that referenced this pull request Aug 27, 2026
Schema:
* import the generic FMI layered standard manifest schema
* Change name to fmiDAEManifest
* keep DAE root and child elements unnamespaced (removed targetNamespace)

manifest.adoc:
* Remove nominal element after discussion with @t-sommer. Instead a nominal attribute for the `<AlgebraicVariable>` element is added. Compare with modelica/Reference-FMUs#690
* Update root name to fmiDAEManifest
@t-sommer
t-sommer merged commit 72bf62c into modelica:main Sep 2, 2026
15 of 16 checks passed
elmir-nahodovic added a commit to modelica/fmi-ls-dae that referenced this pull request Sep 2, 2026
* Update manifest

In summary:
Remove formulation, remove index attribute, update docs, update schema

* Update mathematical notation to use `a` instead of `z` for algebraic variables (to not conflict with core standard)
* Remove <Formulation> element
* Remove  (plural, enclosing) <AlgebraicVariables> element (instead <AlgebraicVariable> is just listed under the manifest)
* Add <Nominal> element, closing issue #61
* removed index attribute from the residual element (until we have a better proposal for higher index formulations)
* Remove annotation TODO. Not sure what should be there.
* Updating Hello World Example XMLs

* Update schema

* Update reference-FMUs fmi-ls-manifest.xml

* Update fmi-ls-manifest-example.xml

* Iteration on standard and schema

Schema:
* import the generic FMI layered standard manifest schema
* Change name to fmiDAEManifest
* keep DAE root and child elements unnamespaced (removed targetNamespace)

manifest.adoc:
* Remove nominal element after discussion with @t-sommer. Instead a nominal attribute for the `<AlgebraicVariable>` element is added. Compare with modelica/Reference-FMUs#690
* Update root name to fmiDAEManifest

* Restore fmi3LayeredStandardManifest

* Update fmi3LayeredStandardDaeManifest.xsd

* Updated to fit the schema
* Removed namespace for root element fmiDAEManifest

* One more iteration on schema and examples

* Restore algebraic container and other small fixes with xsd

* Restore AlgebraicVariables container
* Remove nominal element
* Update xsd
* Update example XMLs

* Simplify XSD schema

* Add XSD dependencies

* Refactor manifest schema

* Fix trailing whitespace

* Correct sequence ModelStructure XMLs

* minOccurs and maxOccurs for AlgebraicVariables and ModelStructure

* Add required elements to example xml

* Untabify schema file to match FMI conventions

* Replace duplicated FMI schemas with github references

* Update workflow to handle remote schema references

* Fix reference FMU example for new schema

* Adjust name of `EnableDAEParameter` element in docs

* Name of `enableDAEModeVariable` -> `enableDAEModeParameter`

---------

Co-authored-by: Torsten Sommer <torsten.sommer@3ds.com>
Co-authored-by: Pierre R. Mai <pmai@pmsf.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants