fix: preserve tag filters during procedure batch expansion - #1599
Open
mvanhorn wants to merge 1 commit into
Open
fix: preserve tag filters during procedure batch expansion#1599mvanhorn wants to merge 1 commit into
mvanhorn wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update each Procedure batch match arm to pass the request's tags into the shared expansion helper along with its pattern. Make the helper build the same tag-aware
ResourceQueryused by direct batch execution, loading the tag catalog only when a non-empty filter must be resolved and retaining the existing no-filter behavior for an empty list. Procedure stages expand batch executions into individual executions before running them. That expansion currently forwards each batch request'spatternbut replaces its resource query with the default, sotagsare discarded and stacks outside the requested tag set can be selected.A Procedure
BatchPullStackexecution with pattern*and tagauto-pullexpands only stacks carryingauto-pull, excluding a stack tagged onlylocal-build; A Procedure batch execution with multiple requested tags preserves the default all-tags matching behavior instead of dropping or weakening the filter.Closes #1596