Open
Conversation
richard-vogl
approved these changes
Jun 21, 2024
richard-vogl
left a comment
richard-vogl
left a comment
There was a problem hiding this comment.
looks good! I hope these bytes are still UTF-8 😄
It appears it is UTF-8, just checked... |
alvesfelipe
approved these changes
Jun 21, 2024
Contributor
alvesfelipe
left a comment
alvesfelipe
left a comment
There was a problem hiding this comment.
$ poetry lock and have fun!
Member
|
@fdlm just bumping this here in case it was forgotten and not intentionally left unmerged (both Rich and Alves approved it). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python's standard
jsonlibrary can produce invalid JSON files, for example if we serializenan,+infor-inffloating point values.I replaced it with
orjson, which is faster and produces compliant JSON files.One important difference is that
orjsonserializes tobytesinstead ofstr. I checked with some files, and the results of the old serialization withjsonandorjsonwere exactly the same, so I think we're fine.