Skip to content

fix: remove event listener declarations to avoid memory leak #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: remove event listener declarations to avoid memory leak #407

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dcbc814
fix: remove event listener declarations to avoid memory leak
Freezystem Sep 1, 2025
3cb9e89
remove useless tests
Freezystem Sep 1, 2025
bda7680
also remove event listener in mongodb adapter
Freezystem Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions packages/moleculer-db-adapter-mongo/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,11 +60,6 @@ class MongoDbAdapter {
this.collection = this.db.collection(this.service.schema.collection);

this.service.logger.info("MongoDB adapter has connected successfully.");

/* istanbul ignore next */
this.db.on("close", () => this.service.logger.warn("MongoDB adapter has disconnected."));
this.db.on("error", err => this.service.logger.error("MongoDB error.", err));
this.db.on("reconnect", () => this.service.logger.info("MongoDB adapter has reconnected."));
});
}

Expand Down
10 changes: 0 additions & 10 deletions packages/moleculer-db-adapter-mongo/test/unit/index.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,6 @@ describe("Test MongoDbAdapter", () => {
});

it("call connect with uri", () => {
fakeDb.on.mockClear();
fakeDb.collection.mockClear();

adapter.opts = undefined;
Expand All @@ -119,10 +118,6 @@ describe("Test MongoDbAdapter", () => {
expect(adapter.client.db).toHaveBeenCalledWith(undefined);

expect(adapter.db).toBe(fakeDb);
expect(adapter.db.on).toHaveBeenCalledTimes(3);
expect(adapter.db.on).toHaveBeenCalledWith("close", expect.any(Function));
expect(adapter.db.on).toHaveBeenCalledWith("error", expect.any(Function));
expect(adapter.db.on).toHaveBeenCalledWith("reconnect", expect.any(Function));

expect(adapter.db.collection).toHaveBeenCalledTimes(1);
expect(adapter.db.collection).toHaveBeenCalledWith("posts");
Expand All @@ -135,7 +130,6 @@ describe("Test MongoDbAdapter", () => {
fakeConn.connect.mockClear();
fakeConn.db.mockClear();

fakeDb.on.mockClear();
fakeDb.collection.mockClear();

adapter.opts = {
Expand All @@ -156,10 +150,6 @@ describe("Test MongoDbAdapter", () => {
expect(adapter.client.db).toHaveBeenCalledWith("demo-db");

expect(adapter.db).toBe(fakeDb);
expect(adapter.db.on).toHaveBeenCalledTimes(3);
expect(adapter.db.on).toHaveBeenCalledWith("close", expect.any(Function));
expect(adapter.db.on).toHaveBeenCalledWith("error", expect.any(Function));
expect(adapter.db.on).toHaveBeenCalledWith("reconnect", expect.any(Function));

expect(adapter.db.collection).toHaveBeenCalledTimes(1);
expect(adapter.db.collection).toHaveBeenCalledWith("posts");
Expand Down
5 changes: 0 additions & 5 deletions packages/moleculer-db-adapter-mongoose/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,11 +96,6 @@ class MongooseDbAdapter {
}

this.service.logger.info("MongoDB adapter has connected successfully.");

/* istanbul ignore next */
this.conn.on("disconnected", () => this.service.logger.warn("Mongoose adapter has disconnected."));
this.conn.on("error", err => this.service.logger.error("MongoDB error.", err));
this.conn.on("reconnected", () => this.service.logger.info("Mongoose adapter has reconnected."));
}

/**
Expand Down
14 changes: 0 additions & 14 deletions packages/moleculer-db-adapter-mongoose/test/unit/index.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,8 +154,6 @@ if (process.versions.node.split(".")[0] < 14) {
});

it("call connect with uri", () => {
fakeDb.on.mockClear();

adapter.opts = undefined;
adapter.model = jest.fn(() => fakeModel);

Expand All @@ -170,21 +168,10 @@ if (process.versions.node.split(".")[0] < 14) {
);

expect(adapter.db).toBe(fakeDb);
expect(adapter.db.on).toHaveBeenCalledTimes(3);
expect(adapter.db.on).toHaveBeenCalledWith(
"disconnected",
expect.any(Function)
);
expect(adapter.db.on).toHaveBeenCalledWith(
"reconnected",
expect.any(Function)
);
});
});

it("call connect with uri & opts", () => {
fakeDb.on.mockClear();

adapter.opts = {
user: "admin",
pass: "123456",
Expand Down Expand Up @@ -241,7 +228,6 @@ if (process.versions.node.split(".")[0] < 14) {
});

it("call connect with schema and modelName", () => {
fakeDb.on.mockClear();
const service = broker.createService({
name: "store",
schema: fakeSchema,
Expand Down