fix(create-update): reject unsupported mentions#244
Open
Gujiassh wants to merge 1 commit intomondaycom:masterfrom
Open
fix(create-update): reject unsupported mentions#244Gujiassh wants to merge 1 commit intomondaycom:masterfrom
Gujiassh wants to merge 1 commit intomondaycom:masterfrom
Conversation
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UpdateMention/mentions_listfields from the sharedcreate_updatemutation so plain update creation no longer fails against monday's current schemamentionsListis provided instead of sending an API request that the schema cannot satisfyparentIdreplies working, and cover the compatibility change with focused create-update testsValidation
cd packages/agent-toolkit && npx jest src/core/tools/platform-api-tools/create-update-tool/create-update-tool.test.ts --runInBandcd packages/agent-toolkit && npx eslint src/core/tools/platform-api-tools/create-update-tool/create-update.graphql.ts src/core/tools/platform-api-tools/create-update-tool/create-update-tool.ts src/core/tools/platform-api-tools/create-update-tool/create-update-tool.test.ts src/core/tools/platform-api-tools/create-update-tool-ui/create-update-ui-tool.ts --max-warnings=0cd packages/agent-toolkit && yarn build