RUBY-3620 - Add Session.escape functionality#2917
Open
johnnyshields wants to merge 1 commit intomongodb:masterfrom
Open
RUBY-3620 - Add Session.escape functionality#2917johnnyshields wants to merge 1 commit intomongodb:masterfrom
johnnyshields wants to merge 1 commit intomongodb:masterfrom
Conversation
Contributor
Author
|
@jamis @comandeo-mongo I've raised 3 semi-related PRs:
As our app has grown in complexity, it is important to have greater ability to control query execution per session. Can you please review these changes and let me know if the approach is acceptable, or if you envision a different way of addressing the use cases? Importantly, #2917 and #2918 may appear similar on the surface, but they actually address two different use cases. Our app would benefit from having them both. Once you have reviewed, I or someone on my team will write the tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per RUBY-3620, when using a Session transaction, there is no easy way to "escape" out of that transaction on the thread** and execute a one-off query. This is useful when you have queries that you want to execute regardless of whether the transaction succeeds or fails.
This PR adds
Mongo::Session.escape { }to force executing queries outside the transaction.(**you can spawn a new thread as a hacky workaround, but this comes with a host of it's own problems, such as needing to transfer in thread-specific state such as I18n.locale or Time.zone)