Fix #369: add Unregister-AntigravityMcp to PowerShell uninstaller - #370
Open
NyxSpecter4 wants to merge 1 commit into
Open
Fix #369: add Unregister-AntigravityMcp to PowerShell uninstaller#370NyxSpecter4 wants to merge 1 commit into
NyxSpecter4 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #369
The PowerShell uninstaller (
scripts/uninstall-monk-agent.ps1) never removed the Antigravity MCP server registration thatstart-monk-agent.ps1creates viaRegister-AntigravityMcp. After uninstall on Windows, a deadmonkentry remained in~/.gemini/config/mcp_config.jsonpointing at a binary that no longer exists. The POSIX uninstaller already callsremove_antigravity_mcp()— this restores platform parity.What changed
Unregister-AntigravityMcptouninstall-monk-agent.ps1, mirroringRegister-AntigravityMcp(same path logic, JSON parse/remove/write with temp-file swap).uninstall completemessage.monkserver entry; drops themcpServerskey if it becomes empty.Verification
uninstall-monk-agent.shalready callsremove_antigravity_mcp()(2 refs) — unchanged.Register-AntigravityMcpstill idempotent on install;Unregister-AntigravityMcpis its inverse on uninstall.mainsource; cannot run Windows PowerShell CI here, but the JSON edit path is the same safe temp-swap pattern the launcher already uses.Happy to adjust if the maintainers prefer the function live in a shared module.