fix: bound Windows agent download stalls - #376
Open
paulcakeface wants to merge 1 commit into
Open
Conversation
Author
|
Bounty-deadline review nudge: the Windows download-stall fix is current against |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #375.
The Windows PowerShell bootstrap currently uses unbounded
Invoke-WebRequestfile downloads. A server/proxy can accept the request (or send response headers and a few archive bytes) and then stop making progress, leaving the blocking SessionStart installer waiting indefinitely.This change:
MONK_AGENT_DOWNLOAD_CONNECT_TIMEOUT(default 10s) andMONK_AGENT_DOWNLOAD_STALL_TIMEOUT(default 30s);HttpWebRequeststreaming helper with separate request and read/write deadlines, so a slow-but-progressing archive is not subject to a short absolute transfer cap;Validation performed before opening:
header_stall=bounded body_stall=bounded copies=3;get.monk.ioWindows artifact completed successfully in ~9s.This is the independent Windows PowerShell counterpart to #360 / #361, which only changes the POSIX shell installer.