Conversation
ZacLou
force-pushed
the
fix-block-monk-shell-separators
branch
2 times, most recently
from
September 5, 2026 07:43
0cfc107 to
83274fa
Compare
ZacLou
marked this pull request as draft
September 5, 2026 08:37
ZacLou
force-pushed
the
fix-block-monk-shell-separators
branch
from
September 16, 2026 10:03
83274fa to
edf8cf3
Compare
The fallback regex in block-monk.ps1 and block-monk.sh treated whitespace/EOL as the only valid trailing boundary, so commands like 'monk;ls', 'monk&ls', 'monk|ls', and 'monk&&ls' were allowed when the monk-agent binary was unavailable. Extend the trailing boundary to include shell separators (; & | ) }) and end-of-string. Fixes monk-io#471.
ZacLou
force-pushed
the
fix-block-monk-shell-separators
branch
from
September 16, 2026 20:25
edf8cf3 to
da81177
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #471.
The fallback regex in �lock-monk.ps1 and �lock-monk.sh treated whitespace/EOL as the only valid trailing boundary. Commands like monk;ls, monk&ls, monk|ls, and monk&&ls were therefore allowed when the monk-agent binary was unavailable and the native fallback ran.
Changes:
Verification: