Repository navigation
nsq: Fix cherry pick where connections are stored indefinitely - #10
Merged
Merged
Conversation
In the cherry pick from 2021: 1fd2297 We didn't include the removal from the map, and thus this caused connections to be tracked indefinitely
YoSmudge
approved these changes
Aug 20, 2026
YoSmudge
left a comment
YoSmudge
left a comment
There was a problem hiding this comment.
This all looks good and matches the upstream changes 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the cherry pick from 2021: 1fd2297
We didn't include the removal from the map, and thus this caused connections to be tracked indefinitely