Skip to content

Conversation

@nanocryk
Copy link
Contributor

Move them in tanssi-runtime-common with feature relay so that other runtimes don't pull unnecessary dependencies.

Do you see other common types that are worth moving too?

@nanocryk nanocryk added a0-pleasereview Pull request needs code review. B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit not-breaking Does not need to be mentioned in breaking changes labels Jun 25, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jun 25, 2025

WASM runtime size check:

Compared to target branch

dancebox runtime: 1688 KB (+4 KB) ⚠️

flashbox runtime: 1040 KB (no changes) ✅

dancelight runtime: 2448 KB (no changes) 🚨

starlight runtime: 2360 KB (+4 KB) ⚠️

container chain template simple runtime: 1336 KB (-4 KB) ✅

container chain template frontier runtime: 1628 KB (no changes) ✅

@github-actions
Copy link
Contributor

github-actions bot commented Jun 25, 2025

Coverage Report

(master)

@@                        Coverage Diff                        @@
##           master   jeremy-refator-common-structs      +/-   ##
=================================================================
- Coverage   65.58%                          65.56%   -0.02%     
  Files         501                             501              
- Lines       82914                           82859      -55     
=================================================================
- Hits        54378                           54325      -53     
- Misses      28536                           28534       -2     
Files Changed Coverage
/chains/orchestrator-paras/runtime/dancebox/src/lib.rs 90.04% (+0.01%)
/chains/orchestrator-relays/runtime/dancelight/src/bridge_to_ethereum_config.rs 84.68% (-1.58%)
/chains/orchestrator-relays/runtime/dancelight/src/lib.rs 68.78% (-0.49%)
/chains/orchestrator-relays/runtime/starlight/src/bridge_to_ethereum_config.rs 57.14% (-29.22%)
/chains/orchestrator-relays/runtime/starlight/src/lib.rs 32.88% (-1.07%)
/chains/runtime-common/src/lib.rs 73.91% (+9.62%)

Coverage generated

@girazoki
Copy link
Contributor

girazoki commented Jun 25, 2025

yeah from a quick look I see:
pub struct SessionTimer<Delay>(PhantomData<Delay>);
pub struct CandidateHasRegisteredKeys;
BabeSlotBeacon
BabeCurrentBlockRandomnessGetter
BabeGetRandomnessForNextBlock
DanceilghtRegitrarHooks and StarlightRegistrarHooks which likely can be renamed

Copy link
Contributor

@ParthDesai ParthDesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nanocryk nanocryk added A8-mergeoncegreen Pull request is reviewed well. and removed a0-pleasereview Pull request needs code review. labels Jul 16, 2025
@nanocryk nanocryk enabled auto-merge (squash) July 16, 2025 09:23
@nanocryk nanocryk disabled auto-merge July 16, 2025 09:47
@nanocryk nanocryk enabled auto-merge (squash) July 17, 2025 13:54
@nanocryk nanocryk merged commit 4624970 into master Jul 18, 2025
58 checks passed
@nanocryk nanocryk deleted the jeremy-refator-common-structs branch July 18, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A8-mergeoncegreen Pull request is reviewed well. B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit not-breaking Does not need to be mentioned in breaking changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants