-
Notifications
You must be signed in to change notification settings - Fork 72
Refactor common types within Dancelight and Starlight #1106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WASM runtime size check:Compared to target branchdancebox runtime: 1688 KB (+4 KB) flashbox runtime: 1040 KB (no changes) ✅ dancelight runtime: 2448 KB (no changes) 🚨 starlight runtime: 2360 KB (+4 KB) container chain template simple runtime: 1336 KB (-4 KB) ✅ container chain template frontier runtime: 1628 KB (no changes) ✅ |
Coverage Report@@ Coverage Diff @@
## master jeremy-refator-common-structs +/- ##
=================================================================
- Coverage 65.58% 65.56% -0.02%
Files 501 501
- Lines 82914 82859 -55
=================================================================
- Hits 54378 54325 -53
- Misses 28536 28534 -2
|
chains/orchestrator-relays/runtime/dancelight/src/bridge_to_ethereum_config.rs
Show resolved
Hide resolved
|
yeah from a quick look I see: |
ParthDesai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Move them in
tanssi-runtime-commonwith featurerelayso that other runtimes don't pull unnecessary dependencies.Do you see other common types that are worth moving too?