Skip to content

Conversation

@tmpolaczyk
Copy link
Contributor

@tmpolaczyk tmpolaczyk commented Oct 28, 2025

paritytech/polkadot-sdk#8072

Latest polkadot-sdk release includes a new feature that allows parachain nodes to advertise their IP address in the relay chain DHT (kademlia). This allows other nodes to discover peers without a centralized peer list.

In this PR we implement it for all nodes, including collators and data preservers. Container chain collators do not advertise their IP address, but they do discover bootnodes for the chain they are assigned to. The reason for not advertising is that collators may rotate frequently, and also that they don't have the full block history. So collators can only be valid targets for warp sync, not for full sync.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 28, 2025

WASM runtime size check:

Compared to target branch

dancebox runtime: 1896 KB (no changes) ✅

flashbox runtime: 1132 KB (no changes) ✅

dancelight runtime: 2672 KB (no changes) 🚨

starlight runtime: 2576 KB (no changes) 🚨

container chain template simple runtime: 1468 KB (no changes) ✅

container chain template frontier runtime: 1824 KB (no changes) ✅

@github-actions
Copy link
Contributor

github-actions bot commented Oct 28, 2025

Coverage Report

(master)

@@                   Coverage Diff                    @@
##           master   tomasz-dht-bootnodes      +/-   ##
========================================================
- Coverage   71.01%                 70.19%   -0.82%     
  Files         550                    550              
+ Lines       75389                  75553     +164     
========================================================
- Hits        53535                  53028     -507     
+ Misses      21854                  22525     +671     
Files Changed Coverage
/chains/orchestrator-relays/client/cli/src/cli.rs 0.00% (-100.00%)
/chains/orchestrator-relays/client/cli/src/command.rs 36.27% (-12.26%)
/chains/orchestrator-relays/node/tanssi-relay-service/src/chain_spec.rs 37.56% (-28.05%)
/chains/orchestrator-relays/node/tanssi-relay-service/src/dev_rpcs.rs 0.00% (-37.50%)
/chains/orchestrator-relays/node/tanssi-relay-service/src/dev_service.rs 41.92% (-47.75%)
/chains/orchestrator-relays/runtime/dancelight/src/genesis_config_presets.rs 50.94% (-4.79%)
/chains/orchestrator-relays/runtime/starlight/src/genesis_config_presets.rs 50.60% (-4.82%)
/client/node-common/src/service/node_builder.rs 41.10% (-3.23%)
/client/service-container-chain-spawner/src/service.rs 1.77% (-0.14%)
/client/service-container-chain-spawner/src/spawner.rs 38.75% (-0.12%)

Coverage generated

Base automatically changed from tanssi-polkadot-stable2506 to master November 3, 2025 12:21
But not for collators nor data preservers
@tmpolaczyk tmpolaczyk changed the title Impl DHT bootnodes support for templates and tanssi-node Impl DHT bootnodes support for all nodes Nov 19, 2025
@tmpolaczyk tmpolaczyk marked this pull request as ready for review November 19, 2025 14:54
@tmpolaczyk tmpolaczyk added B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes breaking Needs to be mentioned in breaking changes A8-mergeoncegreen Pull request is reviewed well. labels Nov 20, 2025
@tmpolaczyk tmpolaczyk added the D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. label Dec 4, 2025
Copy link
Contributor

@nanocryk nanocryk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nitpick, otherwise looks good :)

* Add zombienet suite to weekly bundle
* Simplify if
* Remove TODO
@tmpolaczyk tmpolaczyk requested a review from a team as a code owner December 11, 2025 13:56
@tmpolaczyk tmpolaczyk enabled auto-merge (squash) December 11, 2025 17:25
@tmpolaczyk tmpolaczyk merged commit 9b03db1 into master Dec 11, 2025
75 of 78 checks passed
@tmpolaczyk tmpolaczyk deleted the tomasz-dht-bootnodes branch December 11, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A8-mergeoncegreen Pull request is reviewed well. B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes breaking Needs to be mentioned in breaking changes D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants