-
Notifications
You must be signed in to change notification settings - Fork 72
Impl DHT bootnodes support for all nodes #1344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WASM runtime size check:Compared to target branchdancebox runtime: 1896 KB (no changes) ✅ flashbox runtime: 1132 KB (no changes) ✅ dancelight runtime: 2672 KB (no changes) 🚨 starlight runtime: 2576 KB (no changes) 🚨 container chain template simple runtime: 1468 KB (no changes) ✅ container chain template frontier runtime: 1824 KB (no changes) ✅ |
But not for collators nor data preservers
f6e252a to
e8f397f
Compare
nanocryk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nitpick, otherwise looks good :)
7966232 to
451d507
Compare
paritytech/polkadot-sdk#8072
Latest polkadot-sdk release includes a new feature that allows parachain nodes to advertise their IP address in the relay chain DHT (kademlia). This allows other nodes to discover peers without a centralized peer list.
In this PR we implement it for all nodes, including collators and data preservers. Container chain collators do not advertise their IP address, but they do discover bootnodes for the chain they are assigned to. The reason for not advertising is that collators may rotate frequently, and also that they don't have the full block history. So collators can only be valid targets for warp sync, not for full sync.