let on_delete() return false to skip deletion#1
Open
edam wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the
on_delete()function returnsfalse, the library skips the deletion of the row.Returning
true(ornil) causes the row to be deleted as normal, so this change has no effect on existing code.Note that when an row is not deleted, it will ordinarily retain its position in the index and be a candidate for deletion on the next pass. Therefore, user should be warned that if they return
falsefromon_delete(), then they must either:a. modify the expiration field (to prolong the row from expiry),
b. delete the row themselves, or
a. expect another deletion attempt immediately.