Ignored decommissionRegCenterFail_WithMappedRegCenter testcase [MOSIP-44916]

[GOKULRAJ136]

Summary by CodeRabbit

• Tests
  • Disabled a test method to prevent execution during test runs.

Note: This is an internal change with no impact on end-user functionality.

[coderabbitai]

Walkthrough

A test method in the registration center controller test class is marked as ignored by adding the @Ignore annotation and importing org.junit.Ignore. This prevents the decommissionRegCenterFail_WithMappedRegCenter() test from executing during test runs.

Changes

Cohort / File(s)	Summary
Test Method Ignore admin/kernel-masterdata-service/src/test/java/io/mosip/kernel/masterdata/test/controller/RegistrationCenterControllerTest.java	Added org.junit.Ignore import and applied @Ignore annotation to decommissionRegCenterFail_WithMappedRegCenter() test method to skip execution.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A test sleeps now, marked with @Ignore,
No longer shall it run and tire.
The registry center dreams in peace,
While assertions give their release.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically describes the main change: ignoring a specific test case with its exact name and associated ticket number.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (1)

admin/kernel-masterdata-service/src/test/java/io/mosip/kernel/masterdata/test/controller/RegistrationCenterControllerTest.java (1)

512-515: Add a reason to @Ignore and reference the ticket.

Disabling a test without context makes it easy to forget. Please include a descriptive reason (and ideally the JIRA ID) so future maintainers understand why this is skipped and when to re-enable it.

♻️ Suggested change

-	`@Ignore`
+	`@Ignore`("MOSIP-44916: temporarily disabled - revisit once mapped reg-center decommission flow is fixed")
 	`@Test`
 	`@WithUserDetails`("global-admin")
 	public void decommissionRegCenterFail_WithMappedRegCenter() throws Exception {

Also consider tracking this with a follow-up issue so the ignored test does not become permanently dead code.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In
`@admin/kernel-masterdata-service/src/test/java/io/mosip/kernel/masterdata/test/controller/RegistrationCenterControllerTest.java`
around lines 512 - 515, The `@Ignore` on the test method
decommissionRegCenterFail_WithMappedRegCenter lacks a reason; update the
annotation to include a concise explanation and reference to the tracking ticket
(e.g., JIRA ID) so maintainers know why it's skipped and can find the follow-up
(add the reason string inside `@Ignore`("...") next to the method
decommissionRegCenterFail_WithMappedRegCenter and ensure the message mentions
the ticket ID).

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In
`@admin/kernel-masterdata-service/src/test/java/io/mosip/kernel/masterdata/test/controller/RegistrationCenterControllerTest.java`:
- Around line 512-515: The `@Ignore` on the test method
decommissionRegCenterFail_WithMappedRegCenter lacks a reason; update the
annotation to include a concise explanation and reference to the tracking ticket
(e.g., JIRA ID) so maintainers know why it's skipped and can find the follow-up
(add the reason string inside `@Ignore`("...") next to the method
decommissionRegCenterFail_WithMappedRegCenter and ensure the message mentions
the ticket ID).

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 10ecafcf-c9be-477f-b817-5b26360ab0ff

📥 Commits

Reviewing files that changed from the base of the PR and between d38ec73 and ae6b93f.

📒 Files selected for processing (1)

• admin/kernel-masterdata-service/src/test/java/io/mosip/kernel/masterdata/test/controller/RegistrationCenterControllerTest.java