[DSD-10347] 1.3.1 Packet Processing Performance Tuning release#320
Conversation
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
Warning Review limit reached
More reviews will be available in 55 minutes and 33 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThis PR moves deployment and build artifacts from snapshot/develop to release candidate 1.3.1-rc.1: Helm chart and installer, Helm values (image tag and JVM options), and Maven project/module/dependency versions are updated accordingly. ChangesRelease Candidate 1.3.1-rc.1 Promotion
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: Prafulrakhade <prafulrakhade02@gmail.com>
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@helm/packetmanager/values.yaml`:
- Around line 124-125: The javaOpts string currently enables TRACE logging for
the AWS SDK via the flags -Dlogging.level.com.amazonaws=TRACE,
-Dlogging.level.com.amazonaws.request=TRACE, and
-Dlogging.level.com.amazonaws.http=TRACE; change those three flags to a less
verbose level (e.g., INFO or DEBUG) appropriate for a release candidate and
remove any stray TRACE entries so the javaOpts value uses
-Dlogging.level.com.amazonaws=INFO (or DEBUG) and updates the corresponding
.request and .http flags to the same safer level to avoid excessive/sensitive
logging while preserving the rest of the JVM options.
- Around line 49-50: The values.yaml entry uses repository:
mosipid/commons-packet-service and tag: 1.3.1-rc.1 which 404s on Docker Hub; fix
by replacing the invalid tag with a published one (or the correct image name),
e.g. update tag to an existing tag or change repository to the correct
registry/repo:tag that contains the image; verify the chosen image exists on the
registry (Docker Hub or internal), update the values.yaml fields (repository
and/or tag) accordingly, and re-deploy (helm upgrade) once the image reference
is confirmed.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: eb0b3156-16c7-4abd-b568-c70cdc519f57
📒 Files selected for processing (3)
deploy/install.shhelm/packetmanager/Chart.yamlhelm/packetmanager/values.yaml
Signed-off-by: Prafulrakhade <prafulrakhade02@gmail.com>
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@commons-packet/commons-packet-manager/pom.xml`:
- Around line 32-40: The pom still uses a mutable SNAPSHOT for
kernel-keymanager-service.version; update the property
kernel-keymanager-service.version from 1.4.1-SNAPSHOT to the matching
non-SNAPSHOT RC value (e.g. 1.4.1-rc.1) so the release resolves immutable
artifacts, and scan the other pom properties to ensure no remaining SNAPSHOT
entries remain.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 2b9a3ec5-8378-41b2-81cf-7a2c9f8a741c
📒 Files selected for processing (3)
commons-packet/commons-packet-manager/pom.xmlcommons-packet/commons-packet-service/pom.xmlcommons-packet/pom.xml
Automated PR for release.
Summary by CodeRabbit