Conversation
MichaIng
force-pushed
the
noshell
branch
2 times, most recently
from
July 1, 2026 21:46
12707e7 to
54259d1
Compare
* For the ffmpeg codecs list with hardcoded command, it was safe but unnecessary. * When defining the command as list in the first place, `shlex.quote()` is not needed, and `.split()` can be skipped. * For timelapse movies from a list of pictures, the FFmpeg's concat extension can be used instead of image2pipe, which allows to pipe the list of files to ffmpeg from Python, rather than the content of the files from shell, so that shell=True is not needed. Adding `-y` to let ffmpeg overwrite an existing output file automatically, renders the prior file removal obsolete as well. This commit adds some typing as well. Signed-off-by: MichaIng <micha@dietpi.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
shlex.quote()is not needed, and.split()can be skipped.shell=Trueis not needed. Adding-yto let ffmpeg overwrite an existing output file automatically, renders the prior file removal obsolete as well.This commit adds some typing as well.