-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Add FXIOS-13979 - Remove accessory view for perplexity domain #30297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add FXIOS-13979 - Remove accessory view for perplexity domain #30297
Conversation
|
I am fine with this workaround but what happens when user wants to autofill for example when logging into perplexity? Would the autofill stuff still show up ? |
🧹 Tidy commitJust 3 file(s) touched. Thanks for keeping it clean and review-friendly! 🦊 BrowserViewController CheckWe’re tracking the size of
❌ Per-file test coverage gateThe following changed file(s) are below 35.0% coverage:
Client.app: Coverage: 37.14
Generated by 🚫 Danger Swift against 1b4485c |
adudenamedruby
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks fine to me, and approving from my side, but I'm outta the loop re: @issammani 's question, so I'll let him give final approval.
📜 Tickets
Jira ticket
Github issue
💡 Description
perplexitydomain.🎥 Demos
📝 Checklist