Skip to content

Conversation

@PARAIPAN9
Copy link
Collaborator

@PARAIPAN9 PARAIPAN9 commented Oct 31, 2025

📜 Tickets

Jira ticket
Github issue

💡 Description

  • Remove accessory view for perplexity domain.

🎥 Demos

noAV

📝 Checklist

  • I filled in the ticket numbers and a description of my work
  • I updated the PR name to follow our PR naming guidelines
  • I ensured unit tests pass and wrote tests for new code
  • If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
  • If adding telemetry, I read the data stewardship requirements and will request a data review
  • If adding or modifying strings, I read the guidelines and will request a string review from l10n
  • If needed, I updated documentation and added comments to complex code

@PARAIPAN9 PARAIPAN9 requested a review from a team as a code owner October 31, 2025 15:15
@issammani
Copy link
Collaborator

I am fine with this workaround but what happens when user wants to autofill for example when logging into perplexity? Would the autofill stuff still show up ?

@mobiletest-ci-bot
Copy link

mobiletest-ci-bot commented Oct 31, 2025

Warnings
⚠️ Changes detected in files: firefox-ios/Client/TabManagement/Tab.swift. Ensure that necessary updates are also ported to the WebEngine project if required (cc @lmarceau).
Messages
📖 Project coverage: 38.75%

🧹 Tidy commit

Just 3 file(s) touched. Thanks for keeping it clean and review-friendly!

🦊 BrowserViewController Check

We’re tracking the size of BrowserViewController.swift to keep it healthy.

  • ✨ Change in file size: +4 lines

❌ Per-file test coverage gate

The following changed file(s) are below 35.0% coverage:

File Coverage Required
BrowserKit/Sources/Common/Constants/URLConstants.swift 0.0% 35.0%
firefox-ios/Client/Frontend/Browser/BrowserViewController/Views/BrowserViewController.swift 30.7% 35.0%

Client.app: Coverage: 37.14

File Coverage
BrowserViewController.swift 30.7% ⚠️
Tab.swift 58.47%

Generated by 🚫 Danger Swift against 1b4485c

Copy link
Contributor

@adudenamedruby adudenamedruby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine to me, and approving from my side, but I'm outta the loop re: @issammani 's question, so I'll let him give final approval.

@PARAIPAN9 PARAIPAN9 added the Do Not Merge ⛔️ This issue is a work in progress and is not ready to land label Nov 3, 2025
@PARAIPAN9 PARAIPAN9 requested a review from issammani November 6, 2025 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Do Not Merge ⛔️ This issue is a work in progress and is not ready to land

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants