-
Notifications
You must be signed in to change notification settings - Fork 3.1k
[MTE-4988] - refactor bookmark tests with POM #30470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
💪 Quality guardian11 tests files modified. You're a champion of test coverage! 🚀 🥇 Perfect PR sizeSmaller PRs are easier to review. Thanks for making life easy for reviewers! ✨ ✅ Per-file coverageAll changed files meet the threshold of 35.0%. Generated by 🚫 Danger Swift against 45360ef |
| } | ||
|
|
||
| // https://mozilla.testrail.io/index.php?/cases/view/2306907 | ||
| // Smoketest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add Smoketest TAE in the comment to align with the other features
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
| } | ||
|
|
||
| // https://mozilla.testrail.io/index.php?/cases/view/2306909 | ||
| // Smoketest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
| } | ||
|
|
||
| // https://mozilla.testrail.io/index.php?/cases/view/2784448 | ||
| // Smoketest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
mdotb-moz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I add some minor comments, but the PR looks go to me
d3fc912 to
45360ef
Compare
|
🚀 PR merged to |
📜 Tickets
https://mozilla-hub.atlassian.net/browse/MTE-4988
💡 Description
Refactored bookmark smoke tests with Page Object Model