Skip to content

Conversation

@dicarobinho
Copy link
Collaborator

πŸ“œ Tickets

Jira ticket
Github issue

πŸ’‘ Description

Reset summarize timer

πŸŽ₯ Demos

ScreenRecording_11-10-2025.14-58-14_1.mp4
Before After
Demo

πŸ“ Checklist

  • I filled in the ticket numbers and a description of my work
  • I updated the PR name to follow our PR naming guidelines
  • I ensured unit tests pass and wrote tests for new code
  • If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
  • If adding telemetry, I read the data stewardship requirements and will request a data review
  • If adding or modifying strings, I read the guidelines and will request a string review from l10n
  • If needed, I updated documentation and added comments to complex code

@mobiletest-ci-bot
Copy link

mobiletest-ci-bot commented Nov 10, 2025

Messages
πŸ“– Project coverage: 37.31%

🧹 Tidy commit

Just 2 file(s) touched. Thanks for keeping it clean and review-friendly!

πŸ™Œ Friday high-five

Thanks for pushing us across the finish line this week! πŸ™Œ

❌ Per-file test coverage gate

The following changed file(s) are below 35.0% coverage:

File Coverage Required
firefox-ios/Client/Frontend/Browser/BrowserViewController/Extensions/BrowserViewController+TabToolbarDelegate.swift 5.4% 35.0%

Client.app: Coverage: 36.67

File Coverage
BrowserViewController+TabToolbarDelegate.swift 5.39% ⚠️
BrowserViewController.swift 30.29% ⚠️

Generated by 🚫 Danger Swift against 2c9c97c

Comment on lines 1757 to 1758
resetDataClearanceCFRTimer()
resetSummarizeToolbarCFRTimer()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we do this for translations as well? Can we make a method like stopAndDismissCFRs so that it encapsulates the CFR related code with a comment on context?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since PR with dismiss has been reverted, we can't do that refactor. Also, translations CFR don't have this issue, so is not necessary to invalidate it. We can keep the code as it is for now and maybe if there will be more calls for the timer, we can encapsulate all in one method.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if there will be more calls for the timer, we can encapsulate all in one method.

We have two here if you want to encapsulate.

resetDataClearanceCFRTimer()
resetSummarizeToolbarCFRTimer()

Have we tested no issues on iPad as well with this change?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see issues on iPad. @cyndichin

@mergify
Copy link
Contributor

mergify bot commented Nov 11, 2025

This pull request has conflicts when rebasing. Could you fix it @dicarobinho? πŸ™

# Conflicts:
#	firefox-ios/Client/Frontend/Browser/BrowserViewController/Views/BrowserViewController.swift
@dicarobinho dicarobinho marked this pull request as ready for review November 13, 2025 08:15
@dicarobinho dicarobinho requested a review from a team as a code owner November 13, 2025 08:15
@dicarobinho dicarobinho merged commit a656227 into main Nov 18, 2025
8 checks passed
@dicarobinho dicarobinho deleted the afarcasanu/fxios_14055_30467_summarize_homepage branch November 18, 2025 10:06
@github-actions
Copy link
Contributor

πŸš€ PR merged to main, targeting version: 145.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants