-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Bugfix FXIOS-14055 β [S2S] [iOS26] - Incorrect display of the CFR after a specific scenario #30502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix FXIOS-14055 β [S2S] [iOS26] - Incorrect display of the CFR after a specific scenario #30502
Conversation
β¦er a specific scenario
π§Ή Tidy commitJust 2 file(s) touched. Thanks for keeping it clean and review-friendly! π Friday high-fiveThanks for pushing us across the finish line this week! π β Per-file test coverage gateThe following changed file(s) are below 35.0% coverage:
Client.app: Coverage: 36.67
Generated by π« Danger Swift against 2c9c97c |
| resetDataClearanceCFRTimer() | ||
| resetSummarizeToolbarCFRTimer() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we do this for translations as well? Can we make a method like stopAndDismissCFRs so that it encapsulates the CFR related code with a comment on context?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since PR with dismiss has been reverted, we can't do that refactor. Also, translations CFR don't have this issue, so is not necessary to invalidate it. We can keep the code as it is for now and maybe if there will be more calls for the timer, we can encapsulate all in one method.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if there will be more calls for the timer, we can encapsulate all in one method.
We have two here if you want to encapsulate.
resetDataClearanceCFRTimer()
resetSummarizeToolbarCFRTimer()
Have we tested no issues on iPad as well with this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see issues on iPad. @cyndichin
|
This pull request has conflicts when rebasing. Could you fix it @dicarobinho? π |
# Conflicts: # firefox-ios/Client/Frontend/Browser/BrowserViewController/Views/BrowserViewController.swift
|
π PR merged to |
π Tickets
Jira ticket
Github issue
π‘ Description
Reset summarize timer
π₯ Demos
ScreenRecording_11-10-2025.14-58-14_1.mp4
Demo
π Checklist