git-export: RMST-502: add tombstones to ledger files - #1546
Merged
Merged
Conversation
leplatrem
commented
Sep 8, 2026
Comment on lines
+557
to
+558
| "".join( | ||
| f"{timestamp}{LEDGER_TIMESTAMP_SEPARATOR}{rid}\n" |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| "".join( | |
| f"{timestamp}{LEDGER_TIMESTAMP_SEPARATOR}{rid}\n" | |
| "\n".join( | |
| f"{timestamp}{LEDGER_TIMESTAMP_SEPARATOR}{rid}" |
does not add a newline on files with a single entry...
alexcottner
approved these changes
Sep 8, 2026
alexcottner
left a comment
alexcottner
left a comment
Contributor
There was a problem hiding this comment.
Approved, I agree with your one suggestion though
Contributor
Author
Me too |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #1477
First step for RMST-502: deploy this new git-export job that will store tombstones in ledgers files (see #1538). Let it run a few times, stop it, run the backfill of #1545, restart the cronjob.
At this point existing readers should work as usual. Then we can deploy the reader version of #1539 that reads from the ledger files.