Rework climate controller enhancements#1
Conversation
jmartasek
force-pushed
the
climate-improvements-fixes
branch
2 times, most recently
from
0420271 to
c6b8988
Compare
|
Sure, I can rebase in a bit. Yes there was a slightly unrelated change but it was something that was breaking in my system so fixed that whilst I was adding the changes. I have also recently added another switch for changing the presence detection switch of a light controller which I haven't pushed yet. |
mpcaddy
force-pushed
the
climate-improvements
branch
from
c9a0f2a to
9288194
Compare
Based on the original PR JoDehli#463 work by @mpcaddy, this rework adds: Fixes: - Event listener lifecycle: async_added_to_hass() + async_on_remove() - Mode list copied before mutating (avoids shared kwargs corruption) - possibleCapabilities: .get() with default (older firmware compat) - Separate IRoomControllerV2 loop in switch (avoids breaking climate) - Safe .get() access in climate_handler New features: - Door/Window pause: shows as translated preset when openWindow active - Entity categories: sensors = DIAGNOSTIC, override switch = CONFIG - Translations: en/de/cs for preset mode names (schedule, paused) - translation_key on LoxoneRoomControllerV2 for HA-native i18n - Proper device grouping: all IRC entities share one HA device Co-Authored-By: Lilly Code <lillycode@lilly.com>
jmartasek
force-pushed
the
climate-improvements-fixes
branch
from
c6b8988 to
042a04d
Compare
Use translation_key + enum state keys instead of hardcoded English strings. Adds translations for en, de, cs.
jmartasek
force-pushed
the
climate-improvements-fixes
branch
from
042a04d to
91d6f66
Compare
|
There are too many changes and diffs in this... I suggest closing this PR, feels like it is adding more noise than value. Feel free to pick and choose anything from here. Will take a look at this later, you have done a lot of work. |
|
There does look like some useful things in there - along with the noise. I will see if I have time later to have a proper look and compare, although I think most of the changes you might be seeing are the ones I pulled in from rebasing it. As there were some fixes upstream too. |
2 participants
I took your PR for a ride. Tried to fix some stuff, added some other... Tried it on my deployment and seems to be working well.
Do not want to take your work, hence creating this PR against your branch. You branch, however, is a bit behind, so you might need to rebase it. I can then put my changes over that.
Also, you did some reformatting of the original code - I tend to stay away from it (even though I would like to), it just adds noise in the PRs.
Also, I think you might have an unrelated change in the color picker area.
Feel free to push back, I am no expert.
Based on the original PR JoDehli#463 work by @mpcaddy, this rework adds:
Fixes:
New features: