Repository navigation
split polyfill and dev/library dependencies - #179
Merged
romainmenke merged 2 commits intoAug 26, 2026
Merged
romainmenke merged 2 commits into
romainmenke merged 2 commits into
Conversation
fd
approved these changes
Aug 26, 2026
romainmenke
deleted the
split-polyfills-from-dev-dependencies--persistent-dusky-dolphin-fbf8e1eaf2
branch
August 26, 2026 15:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This separates polyfill dependencies from those of other polyfills and dev/library dependencies.
The intention is to allow maintainers to run commands like
npm updateat the root without breaking polyfills.This should also make it easier to triage and resolve security nags for dependencies.
I still think that we should try to avoid 3rd party polyfills.
I don't think the maintenance cost of these is worth it.
Would be different if others actually wrote polyfills in ES3 and in a style that made them suitable for how we bundle/package polyfills, then we could adopt them as-is without intervention or extra tools.