topic (iac): [secure-hybrid-network] update OS and VM SKU to modern Gen2#268
Merged
Conversation
2574078 to
f232f74
Compare
30f3b58 to
8943e04
Compare
e51f2a7 to
077ef76
Compare
ckittel
requested changes
May 28, 2026
| @description('The count of Windows virtual machines to create.') | ||
| param webServerInstanceCount int = 2 | ||
| param vmSize string = 'Standard_A4_v2' | ||
| param vmSize string = 'Standard_D2s_v3' |
Member
There was a problem hiding this comment.
Do you need to update the listed default in the README now?
Contributor
Author
Contributor
There was a problem hiding this comment.
Pull request overview
Modernizes the secure-hybrid-network solution’s nested templates by updating default Windows image SKUs and VM sizes to newer, better-supported options.
Changes:
- Updated default VM size parameters to
Standard_D2s_v3in both ARM JSON and Bicep templates. - Updated Windows Server image SKU variables to Windows Server 2025 Gen2 variants.
- Removed explicit
patchSettingsconfiguration from the mock on-prem VM’s Bicep definition.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| solutions/secure-hybrid-network/nestedtemplates/mock-onprem-azuredeploy.json | Updates default VM size and Windows image SKU for the mock on-prem VM. |
| solutions/secure-hybrid-network/nestedtemplates/mock-onprem-azuredeploy.bicep | Updates default VM size/image SKU and removes explicit Windows patch settings. |
| solutions/secure-hybrid-network/nestedtemplates/azure-network-azuredeploy.json | Updates default VM size and Windows image SKU used by the VMSS. |
| solutions/secure-hybrid-network/nestedtemplates/azure-network-azuredeploy.bicep | Updates default VM size and Windows image SKU used by the VMSS. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
39
to
42
| "vmSize": { | ||
| "type": "string", | ||
| "defaultValue": "Standard_DS1_v2" | ||
| "defaultValue": "Standard_D2s_v3" | ||
| }, |
- Replace Standard_A4_v2 (Gen1-only) with Standard_D2s_v3 (Gen2-capable) - VMSS (web tier): 2025-datacenter-core-smalldisk-g2 (Server Core for IIS) - Mock on-prem VM: 2025-datacenter-smalldisk-g2 (full desktop for Bastion RDP) - Smaller disk, faster boot, reduced attack surface on web tier Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Update parameter tables to reflect new Standard_D2s_v3 default. Co-authored-by: GitHub Copilot (Claude Opus 4.6) <noreply@github.com>
Keep AutomaticByPlatform patch assessment and mode settings on the mock on-premises VM for production-like configuration. Co-authored-by: GitHub Copilot (Claude Opus 4.6) <noreply@github.com>
077ef76 to
82d0fb1
Compare
ckittel
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Windows Server 2016/2022 reached end of mainstream support. Standard_A4_v2 is a legacy SKU with poor price-performance.
What
2025-datacenter-core-smalldisk-g2(Core — no GUI needed)2025-datacenter-smalldisk-g2(full desktop for RDP/browser testing)Test