Skip to content

topic (iac): [secure-hybrid-network] update OS and VM SKU to modern Gen2#268

Merged
ckittel merged 3 commits into
mainfrom
topic/421252_update-os-version
May 28, 2026
Merged

topic (iac): [secure-hybrid-network] update OS and VM SKU to modern Gen2#268
ckittel merged 3 commits into
mainfrom
topic/421252_update-os-version

Conversation

@ferantivero

@ferantivero ferantivero commented May 26, 2026

Copy link
Copy Markdown
Contributor

Why

Windows Server 2016/2022 reached end of mainstream support. Standard_A4_v2 is a legacy SKU with poor price-performance.

What

  • Update VM SKU from Standard_A4_v2 to Standard_D2s_v3 (all templates)
  • Update OS images to Windows Server 2025 Gen2:
    • azure-network (VMSS web servers): 2025-datacenter-core-smalldisk-g2 (Core — no GUI needed)
    • mock-onprem (test VM): 2025-datacenter-smalldisk-g2 (full desktop for RDP/browser testing)
  • Update README parameter tables with new vmSize default
  • Retain patchSettings (AutomaticByPlatform) on mock-onprem VM

Test

  • Bicep compiles without errors

@ferantivero ferantivero force-pushed the topic/421252_tighten-fw-rules branch from 2574078 to f232f74 Compare May 27, 2026 17:21
@ferantivero ferantivero force-pushed the topic/421252_update-os-version branch 2 times, most recently from 30f3b58 to 8943e04 Compare May 27, 2026 17:29
@ferantivero ferantivero changed the base branch from topic/421252_tighten-fw-rules to main May 27, 2026 21:41
@ferantivero ferantivero force-pushed the topic/421252_update-os-version branch 3 times, most recently from e51f2a7 to 077ef76 Compare May 27, 2026 22:27
@ckittel ckittel requested a review from Copilot May 28, 2026 14:48
@description('The count of Windows virtual machines to create.')
param webServerInstanceCount int = 2
param vmSize string = 'Standard_A4_v2'
param vmSize string = 'Standard_D2s_v3'

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to update the listed default in the README now?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are so right @ckittel,

done | addressed from a4d19e2

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Modernizes the secure-hybrid-network solution’s nested templates by updating default Windows image SKUs and VM sizes to newer, better-supported options.

Changes:

  • Updated default VM size parameters to Standard_D2s_v3 in both ARM JSON and Bicep templates.
  • Updated Windows Server image SKU variables to Windows Server 2025 Gen2 variants.
  • Removed explicit patchSettings configuration from the mock on-prem VM’s Bicep definition.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

File Description
solutions/secure-hybrid-network/nestedtemplates/mock-onprem-azuredeploy.json Updates default VM size and Windows image SKU for the mock on-prem VM.
solutions/secure-hybrid-network/nestedtemplates/mock-onprem-azuredeploy.bicep Updates default VM size/image SKU and removes explicit Windows patch settings.
solutions/secure-hybrid-network/nestedtemplates/azure-network-azuredeploy.json Updates default VM size and Windows image SKU used by the VMSS.
solutions/secure-hybrid-network/nestedtemplates/azure-network-azuredeploy.bicep Updates default VM size and Windows image SKU used by the VMSS.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 39 to 42
"vmSize": {
"type": "string",
"defaultValue": "Standard_DS1_v2"
"defaultValue": "Standard_D2s_v3"
},
ferantivero and others added 3 commits May 28, 2026 14:43
- Replace Standard_A4_v2 (Gen1-only) with Standard_D2s_v3 (Gen2-capable)
- VMSS (web tier): 2025-datacenter-core-smalldisk-g2 (Server Core for IIS)
- Mock on-prem VM: 2025-datacenter-smalldisk-g2 (full desktop for Bastion RDP)
- Smaller disk, faster boot, reduced attack surface on web tier

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Update parameter tables to reflect new Standard_D2s_v3 default.

Co-authored-by: GitHub Copilot (Claude Opus 4.6) <noreply@github.com>
Keep AutomaticByPlatform patch assessment and mode settings on
the mock on-premises VM for production-like configuration.

Co-authored-by: GitHub Copilot (Claude Opus 4.6) <noreply@github.com>
@ferantivero ferantivero force-pushed the topic/421252_update-os-version branch from 077ef76 to 82d0fb1 Compare May 28, 2026 17:53
@ckittel ckittel merged commit 96fdcd0 into main May 28, 2026
5 checks passed
@ckittel ckittel deleted the topic/421252_update-os-version branch May 28, 2026 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants