fix(webview): preview-only logging for rejected host messages#227
Merged
Conversation
The validator-rejection branch in subscribeToHost logged the full event.data payload to the console. Align it with the host-side precedent in quoll-editor-panel.ts (handleInbound), which previews only type + top-level keys instead of leaking arbitrary payload content.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
subscribeToHostinsrc/webview/host.tslogged the full rejected inbound payload on validator-rejection, unlike the host-side precedent (quoll-editor-panel.ts'shandleInbound) which previews onlytype+ top-level keys.Changes
src/webview/host.ts: replaceconsole.error(..., event.data)with a{ type, keys }preview in the validator-rejection branch.test/webview/host.test.ts: strengthen the existing "shapeless payload" test to assert the preview shape and that a sensitive field value never reaches the logged output.Related
Test Plan
pnpm compilepnpm test:unitpnpm lint(no findings in touched files)