This repository was archived by the owner on Jan 2, 2020. It is now read-only.
Cleanup pt2 - Small pieces this time#42
Open
sgnn7 wants to merge 14 commits into
Open
Conversation
It was pretty gnarly so it's a bit cleaner now.
Treating all things as objects, especially the launchers makes for easier invocation from other Python objects and cleaner code.
Lots of extra whitespace and imports were pretty messy.
Now we don't import the whole modules always but just the bits and pieces that are needed.
Python standards are to use snake case for module names (in general).
These should never be checked in the repo so we ignore them.
Snake case change again to match standards but I have no clue where this is used. Maybe it should be deleted?
Much cleaner and conforms a bit better to import of those files a bit better.
It's good to have the same license everywhere.
|
|
More moves towards consistency in the naming of modules.
Removed out empty lines, reordered imports, applied a bit of standardization to hanging lines.
There was some code organization that just wasn't needed so it got removed.
Whitespacing and import ordering wasn't the greatest so this change improves the readability a bit.
Normally spacing in xml docs is multiples of 2 while the one in the file was 1 so it got cleaned up.
Author
|
@muelli Any clue when you might take a look at this? I don't think I can do another rewrite of this again if it gets into a rebase abyss :( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just general cleanup without digging too deep into the codebase (yet)