[button] Fix customized flex gap styles#48542
Merged
mj12albert merged 2 commits intoMay 19, 2026
Merged
Conversation
mj12albert
added
scope: button
Deploy previewhttps://deploy-preview-48542--material-ui.netlify.app/ Bundle size
Check out the code infra dashboard for more information about this PR. |
mj12albert
force-pushed
the
fix-button-baseline-icon-alignment
branch
from
611a555 to
33ac7bc
Compare
mj12albert
force-pushed
the
fix-button-baseline-icon-alignment
branch
from
33ac7bc to
fbc66cf
Compare
ZeeshanTamboli
approved these changes
May 19, 2026
Member
ZeeshanTamboli
left a comment
ZeeshanTamboli
left a comment
There was a problem hiding this comment.
Makes sense. Looks good to me.
siriwatknp
reviewed
May 19, 2026
| }, | ||
| })(({ theme }) => ({ | ||
| display: 'inherit', | ||
| alignItems: 'center', |
Member
There was a problem hiding this comment.
I think it is because the ::before content is inside the Icon <span> container, so it would be a flex item.
Member
Author
There was a problem hiding this comment.
Yep it's to keep the icon centered
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preview: https://stackblitz.com/edit/github-5wywe1mb-mc3z3pdg?file=package.json
Fixes #48539