Move mocha to devdependencies#2
Merged
maziyarpanahi merged 3 commits intomultivacplatform:masterfrom Oct 16, 2019
Merged
Conversation
Contributor
Author
|
Also, consider updating |
It's vulnerable, per `npm audit`, so we don't want it in production. Inspired by GitHub user makuro's commit @ 9045d25. makuro/swagger-node@9045d25
DeeDeeG
force-pushed
the
mocha-to-devdependencies
branch
from
f0a327c to
8a83943
Compare
Contributor
Author
|
Hi, I fixed the merge conflict here. |
Member
|
Looks great, thanks @DeeDeeG! Testes have passed and I'll merge this. I'll bump the version to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Basically the same as a PR I made over at upstream: swagger-api/swagger-node#591)
mochais a testing framework, so it shouldn't be needed outside ofdevdependencies.Having fewer
dependenciesobviously pulls in less dependencies, for those who useswaggerin their project. That makes for a lighternode_modulesfolder, less things to keep up-to-date to satisfynpm auditandyarn audit, etc.