force request epoch start header and its proof#7774
force request epoch start header and its proof#7774miiu96 merged 4 commits intofeat/supernova-async-execfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request implements a watchdog mechanism to force request of epoch start headers and their proofs when metablocks are not received for an extended period. The changes enable the shard chain epoch start trigger to proactively request missing epoch start metablocks during the Andromeda epoch, improving resilience when the network experiences delays in metablock propagation.
Changes:
- Added
TimeDuration()method toRoundHandlerinterface to support configurable timeout calculation - Added
RequestEquivalentProofByHash()method toRequestHandlerinterface for requesting missing proofs - Implemented watchdog goroutine that requests epoch start metablocks after 5 rounds without receiving any metablock (when AndromedaFlag is enabled)
- Enhanced
receivedMetaBlock()to automatically request proofs for epoch start headers when missing in Andromeda epoch
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| process/interface.go | Added TimeDuration() method to RoundHandler interface for timeout computation |
| epochStart/interface.go | Added RequestEquivalentProofByHash() method for requesting proofs by hash |
| epochStart/shardchain/trigger.go | Implemented watchdog goroutine, proof request logic, and channel signaling mechanism |
| epochStart/shardchain/trigger_test.go | Added comprehensive test coverage for watchdog functionality and proof requests |
| epochStart/shardchain/triggerRegistry_test.go | Updated test helper to include new channel field |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…request-epoch-start-block
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/supernova-async-exec #7774 +/- ##
=============================================================
+ Coverage 77.51% 77.53% +0.02%
=============================================================
Files 882 882
Lines 123429 123481 +52
=============================================================
+ Hits 95673 95746 +73
+ Misses 21407 21386 -21
Partials 6349 6349 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Reasoning behind the pull request
Proposed changes
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?