Skip to content

force request epoch start header and its proof#7774

Merged
miiu96 merged 4 commits intofeat/supernova-async-execfrom
request-epoch-start-block
Mar 2, 2026
Merged

force request epoch start header and its proof#7774
miiu96 merged 4 commits intofeat/supernova-async-execfrom
request-epoch-start-block

Conversation

@AdoAdoAdo
Copy link
Contributor

Reasoning behind the pull request

Proposed changes

Testing procedure

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request implements a watchdog mechanism to force request of epoch start headers and their proofs when metablocks are not received for an extended period. The changes enable the shard chain epoch start trigger to proactively request missing epoch start metablocks during the Andromeda epoch, improving resilience when the network experiences delays in metablock propagation.

Changes:

  • Added TimeDuration() method to RoundHandler interface to support configurable timeout calculation
  • Added RequestEquivalentProofByHash() method to RequestHandler interface for requesting missing proofs
  • Implemented watchdog goroutine that requests epoch start metablocks after 5 rounds without receiving any metablock (when AndromedaFlag is enabled)
  • Enhanced receivedMetaBlock() to automatically request proofs for epoch start headers when missing in Andromeda epoch

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
process/interface.go Added TimeDuration() method to RoundHandler interface for timeout computation
epochStart/interface.go Added RequestEquivalentProofByHash() method for requesting proofs by hash
epochStart/shardchain/trigger.go Implemented watchdog goroutine, proof request logic, and channel signaling mechanism
epochStart/shardchain/trigger_test.go Added comprehensive test coverage for watchdog functionality and proof requests
epochStart/shardchain/triggerRegistry_test.go Updated test helper to include new channel field

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Feb 27, 2026

Codecov Report

❌ Patch coverage is 96.15385% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.53%. Comparing base (8d1f476) to head (bda7e53).
⚠️ Report is 15 commits behind head on feat/supernova-async-exec.

Files with missing lines Patch % Lines
epochStart/shardchain/trigger.go 96.15% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@                      Coverage Diff                      @@
##           feat/supernova-async-exec    #7774      +/-   ##
=============================================================
+ Coverage                      77.51%   77.53%   +0.02%     
=============================================================
  Files                            882      882              
  Lines                         123429   123481      +52     
=============================================================
+ Hits                           95673    95746      +73     
+ Misses                         21407    21386      -21     
  Partials                        6349     6349              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@miiu96 miiu96 merged commit 8283bc7 into feat/supernova-async-exec Mar 2, 2026
15 checks passed
@miiu96 miiu96 deleted the request-epoch-start-block branch March 2, 2026 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants