This repository was archived by the owner on Jan 2, 2023. It is now read-only.
Add dispatch table and dependencies #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@baszalmstra Should the full function path (i.e. module path + function name) be stored in the ABI? Now we only store the function name, and on runtime always need to combine the module path + function name to store functions in the dispatch table. |
Contributor
Yeah I think it should be the fully qualified path. |
baszalmstra
approved these changes
Oct 11, 2019
Wodann
force-pushed
the
feature/dispatch-table
branch
from
6d9eee7 to
39f28db
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.