You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After #1542 has added support for linear tensors, this PR integrates registers deeper into our infrastructure. Furthermore, it updates our QIR code to use the dynamic allocations introduced in qir-alliance/qir-spec#60.
Some known shortcomings at this point:
Vast majority of failing tests are due to the conversion between QCO and Jeff. The problem is that Jeff's QuregType does not have any information about the register size. I will create an issue and/or follow up on Slack.
The remaining (15 or so) failing tests either have an easy solution that I already have in mind, or I haven't looked at them yet. That said, I don't expect bigger issues at this point.
Existing docstrings are outdated or missing, especially for the conversion from QC to QIR where a lot had changed.
Value stored to 'resultSize' during its initialization is never read
43 | auto resultSize = resultType.getShape()[0];
| ^~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~
/home/runner/work/core/core/mlir/lib/Dialect/QTensor/IR/Operations/AllocOp.cpp:43:8: note: Value stored to 'resultSize' during its initialization is never read
43 | auto resultSize = resultType.getShape()[0];
| ^~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enhancementImprovement of existing featureMLIRAnything related to MLIR
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After #1542 has added support for linear tensors, this PR integrates registers deeper into our infrastructure. Furthermore, it updates our QIR code to use the dynamic allocations introduced in qir-alliance/qir-spec#60.
Some known shortcomings at this point:
QuregTypedoes not have any information about the register size. I will create an issue and/or follow up on Slack.Checklist
I have added migration instructions to the upgrade guide (if needed).