Set Distribution PKG to be the default and fix missing titles with support for title key in build-info.plist#79
Closed
Lotusshaney wants to merge 2 commits intomunki:mainfrom
Closed
Set Distribution PKG to be the default and fix missing titles with support for title key in build-info.plist#79Lotusshaney wants to merge 2 commits intomunki:mainfrom
Lotusshaney wants to merge 2 commits intomunki:mainfrom
Conversation
Changed Default pkg style
Refactor version substitution logic and enhance distribution package creation with title support.
Contributor
|
That's a lot of opinionated changes for a single PR. How about we scale it back to address only the original issue: providing a title in Installer.app when installing a Distribution package. If you want to argue for changing the default behavior to build distribution-style packages, that's fine, but I think that's a separate discussion and separate PR. |
Author
|
Happy for you to do what ever you want with the PR. I wasnt trying to be opinionated |
Author
|
Updated with #80 thats focused only on providing a title in Installer.app when installing a Distribution package. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the default behaviour of munkipkg to set as default distribution_style to True.
Added support for a custom title in distribution_style PKGS using a title key in build-info.plist
The title string supports the use of ${version} variable in the same way the name key does.