Added context to docks#2
Open
Eism wants to merge 2 commits into
Open
Conversation
KDDockWidgets sprinkles invariant asserts across the layout-resize path (ItemBoxContainer::growItem's `toSteal <= available1 + available2` plus the two inner `assert(availableX >= toSteal)`, Item::resizeChildren's `newItemLength > 0`, and etc.). They fire in a number of normal, non-pathological scenarios - restoring a layout into a host view that hasn't reached its final size yet, plain page switches in DockWindow when neighbour placeholders haven't accrued a shrink budget, etc. - and crash debug builds even though release builds fall through and the next onResize corrects the geometry.
Closed
| DockRegistry::DockRegistry(int ctx, Core::Object *parent) | ||
| : DockRegistry(parent) | ||
| { | ||
| const_cast<int &>(m_ctx) = ctx; |
There was a problem hiding this comment.
I think better
DockRegistry::DockRegistry(int ctx, Core::Object *parent)
: DockRegistry(parent), m_ctx(ctx)
{
| static DockRegistry *self(); | ||
|
|
||
| ///@brief Returns the DockRegistry bound to the given context. Owned by ContextData. | ||
| static DockRegistry *self(int ctx); |
There was a problem hiding this comment.
The only thing that confuses me is:
- How can we ensure that
self(ctx)is called everywhere, and notself(), if context is used? - How can we show other developers that they need to call
self(ctx)and pass context in new code?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO (fix later): Also muted assertions in Item.cpp - unfortunately, there were a lot of crashes in MuseScore
Port of musescore/MuseScore#32247