Fix layout of chord brackets and parens#33356
Conversation
|
ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThis PR restructures chord bracket layout in MuseScore's engraving system. Chord brackets are moved from inline processing within the main element loop to a dedicated layout pass that runs after note, fingering, and articulation layout. Correspondingly, the shape filtering logic used for parenthesis spacing calculations is expanded to exclude chord brackets and arpeggios in addition to stems when determining the parent chord shape. 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Resolves: #32471