Skip to content

Fix layout of chord brackets and parens#33356

Open
miiizen wants to merge 1 commit into
musescore:mainfrom
miiizen:32471-bracketParens
Open

Fix layout of chord brackets and parens#33356
miiizen wants to merge 1 commit into
musescore:mainfrom
miiizen:32471-bracketParens

Conversation

@miiizen
Copy link
Copy Markdown
Contributor

@miiizen miiizen commented May 12, 2026

Resolves: #32471

Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 12, 2026

Review Change Stack
No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 0cee8659-0faa-4ee5-b05f-0164ac511e81

📥 Commits

Reviewing files that changed from the base of the PR and between 3c30b96 and 1f75bd1.

📒 Files selected for processing (3)
  • src/engraving/rendering/score/chordlayout.cpp
  • src/engraving/rendering/score/parenthesislayout.cpp
  • vtest/scores/chordBrackets-3.mscz

📝 Walkthrough

Walkthrough

This PR restructures chord bracket layout in MuseScore's engraving system. Chord brackets are moved from inline processing within the main element loop to a dedicated layout pass that runs after note, fingering, and articulation layout. Correspondingly, the shape filtering logic used for parenthesis spacing calculations is expanded to exclude chord brackets and arpeggios in addition to stems when determining the parent chord shape.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is incomplete; it only contains a GitHub issue reference without the required explanation, motivation, or checklist items from the template. Add a brief description of changes, motivation, and fill out the template checklist items to document the solution approach.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Fix layout of chord brackets and parens' directly addresses the main issue and accurately reflects the changes in both modified files.
Linked Issues check ✅ Passed The code changes directly address issue #32471 by modifying chord bracket and parenthesis layout logic to prevent horizontal expansion.
Out of Scope Changes check ✅ Passed Both file changes (chordlayout.cpp and parenthesislayout.cpp) are directly related to fixing the chord bracket and parenthesis layout issue; no out-of-scope changes detected.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bracket plus parenthesis can expand horizontally

2 participants