Skip to content

[MusicXML] improve title box position #33373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RomanPudashkin merged 4 commits into from
May 15, 2026
+4 −4
Merged

[MusicXML] improve title box position #33373

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7ea02c8
fix vbox position
rettinghaus May 12, 2026
b394fba
round title position
rettinghaus May 12, 2026
eb43065
fix test
rettinghaus May 12, 2026
2e49a27
switch back to double
rettinghaus May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/importexport/musicxml/internal/export/exportmusicxml.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1459,8 +1459,8 @@ static void creditWords(XmlWriter& xml, const MStyle& s, const page_idx_t pageNr
if (!creditType.empty()) {
xml.tag("credit-type", creditType);
}
String attr = String(u" default-x=\"%1\"").arg(x);
attr += String(u" default-y=\"%1\"").arg(y);
String attr = String(u" default-x=\"%1\"").arg(String::number(x, 2));
attr += String(u" default-y=\"%1\"").arg(String::number(y, 2));
attr += u" justify=\"" + just + u"\"";
attr += u" valign=\"" + val + u"\"";
MScoreTextToMusicXml mttm(u"credit-words", attr, defFmt, mtf);
Expand Down
2 changes: 1 addition & 1 deletion src/importexport/musicxml/internal/import/importmusicxmlpass1.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1001,7 +1001,7 @@ static void resizeTitleBox(VBox* vbox)
score->renderer()->layoutItem(e);
}

double padding = vbox->spatium();
const double padding = vbox->sizeIsSpatiumDependent() ? vbox->style().spatium() : vbox->style().defaultSpatium();

for (EngravingItem* e : elist) {
if (e->isText()) {
Expand Down
2 changes: 1 addition & 1 deletion src/importexport/musicxml/tests/data/testSystemDistance_ref.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@
</defaults>
<credit page="1">
<credit-type>title</credit-type>
<credit-words default-x="616.9347" default-y="1511.197129" justify="center" valign="top" font-size="22">System-Distance Test</credit-words>
<credit-words default-x="616.93" default-y="1511.2" justify="center" valign="top" font-size="22">System-Distance Test</credit-words>
</credit>
<part-list>
<score-part id="P1">
Expand Down
Loading