Skip to content

Fix audio plugins scanner#33633

Merged
RomanPudashkin merged 1 commit into
musescore:mainfrom
RomanPudashkin:fix_audio_plugins_scanner
May 29, 2026
Merged

Fix audio plugins scanner#33633
RomanPudashkin merged 1 commit into
musescore:mainfrom
RomanPudashkin:fix_audio_plugins_scanner

Conversation

@RomanPudashkin
Copy link
Copy Markdown
Contributor

Ports: #33608
Resolves: #33454
Depends on: musescore/muse_framework#67

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 29, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: ab52dc76-696e-4029-816c-313f38ab8245

📥 Commits

Reviewing files that changed from the base of the PR and between 99a6d69 and aa4f6d4.

📒 Files selected for processing (2)
  • muse
  • src/appshell/internal/startupscenario.cpp

📝 Walkthrough

Walkthrough

This PR contains two independent changes: an update to the muse submodule pointer to reference a newer commit, and a modification to the StartupScenario::registerAudioPlugins() method in the appshell module. The registerAudioPlugins() method previously captured the return value from updatePluginsRegistry() and logged errors when the operation failed; this error-checking code is now removed, and the method call executes without local success or failure handling.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive The PR description includes links to the ported issue and dependencies but lacks the detailed information requested by the template (checklist items, commit message descriptions, testing details). Expand the description with more details about what was changed, testing performed, and complete the template checklist items to clarify the scope.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Fix audio plugins scanner' directly relates to the main changes in the PR, which address audio plugin scanning behavior.
Linked Issues check ✅ Passed The PR addresses the core issue #33454 by preventing automatic audio plugin scans at startup through code changes that update plugin registry handling.
Out of Scope Changes check ✅ Passed The muse submodule update and the removal of error handling in registerAudioPlugins() appear to be directly related to fixing the audio plugin scanner behavior per issue #33454.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@RomanPudashkin RomanPudashkin merged commit da50814 into musescore:main May 29, 2026
15 checks passed
@RomanPudashkin RomanPudashkin deleted the fix_audio_plugins_scanner branch May 29, 2026 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Start VST scan at every program startup

1 participant