Skip to content

Add MUSE_APP_TITLE_VERSION define#76

Closed
kryksyh wants to merge 1 commit into
musescore:mainfrom
kryksyh:add_muse_app_title_version
Closed

Add MUSE_APP_TITLE_VERSION define#76
kryksyh wants to merge 1 commit into
musescore:mainfrom
kryksyh:add_muse_app_title_version

Conversation

@kryksyh
Copy link
Copy Markdown
Collaborator

@kryksyh kryksyh commented Jun 3, 2026

Adds a define so the MUSE_APP_TITLE_VERSION is accessible in the source code

  • I signed the CLA as username:
  • The title of the PR describes the problem it addresses.
  • Each commit's message describes its purpose and effects, and references the issue it resolves. If changes are extensive, there is a sequence of easily reviewable commits.
  • The code in the PR follows the coding rules.
  • I understand all aspects of the code I'm contributing and I'm able to explain it if requested.
  • The code compiles and runs on my machine, preferably after each commit individually. I have manually tested and verified that my changes fulfil their intended purpose.
  • No prior attempts to resolve this problem exist, or if they do, I listed them in my PR description and described how I avoided repeating past mistakes.
  • There are no unnecessary changes.
  • I created a unit test or vtest to verify the changes I made (if applicable).

Build configuration

audacity: audacity/audacity/master
audacity platforms: linux_x64
musescore: musescore/MuseScore/main
musescore platforms: linux_x64

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 3, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 47285192-4952-4014-a3cd-a716e1a938b6

📥 Commits

Reviewing files that changed from the base of the PR and between 1e42a8c and 92619c4.

📒 Files selected for processing (1)
  • framework/cmake/muse_framework_config.h.in

📝 Walkthrough

Walkthrough

This pull request adds a single CMake preprocessor macro definition to the framework configuration template. The change introduces #cmakedefine MUSE_APP_TITLE_VERSION "${MUSE_APP_TITLE_VERSION}" to the muse_framework_config.h.in file, enabling CMake to substitute the application title version value during the header generation process.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: adding a CMake define for MUSE_APP_TITLE_VERSION to make it accessible in source code.
Description check ✅ Passed The description includes the main objective and completes most required checklist items; however, the GitHub issue reference is missing, and the unit test/vtest checkbox is unchecked.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kryksyh
Copy link
Copy Markdown
Collaborator Author

kryksyh commented Jun 3, 2026

Closing this, as it would require MuseScore changes to consolidate variables.

@kryksyh kryksyh closed this Jun 3, 2026
@kryksyh kryksyh deleted the add_muse_app_title_version branch June 3, 2026 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant