Don't stop applying sysupdates before Tor step even on failures

[kristapsk]

Because that may lead to connectivity problems for devices. https://x.com/lontivero/status/2070191111650390466

Summary by CodeRabbit

• Bug Fixes
  • Updated the update process to continue even if certain base OS component scripts fail, rather than stopping everything.
  • Failures are now reported with a “failed, continuing...” message, and the process proceeds to subsequent update steps to improve overall resilience.

[coderabbitai]

Warning

Review limit reached

@kristapsk, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 58 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d539e9cb-6c88-4ae6-8301-3c9a58b43211

📥 Commits

Reviewing files that changed from the base of the PR and between e4a4be7 and b94365c.

📒 Files selected for processing (1)

• apply.sh

Walkthrough

apply.sh now continues after failures in ./base/boot.sh and ./base/voidlinux.sh, records a non-zero exit code, and keeps running later update steps.

Changes

Non-fatal base OS update steps

Layer / File(s)	Summary
Continue-on-error for base OS scripts apply.sh	Replaces || exit 1 with a print-and-continue pattern for ./base/boot.sh and ./base/voidlinux.sh, so failures in those steps no longer abort the script.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐇 I hopped through boot and void with care,
A failed step now stays right there.
I print and keep the update flow,
No sudden stop, just onward go!
The carrot path stays bright and clear.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title matches the main change: sysupdates now keeps going past earlier failures so it can reach the Tor step.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@apply.sh`:
- Line 26: The `voidlinux.sh` fallback in `apply.sh` is not updating
`exit_code`, so failures can still be reported as success. Update the
`./base/voidlinux.sh` invocation to mirror the existing failure handling pattern
used for the other base OS scripts, using `exit_code=1` when it fails and
keeping the warning message on stderr so the script’s final exit status reflects
the error.
- Line 23: Update the `./base/boot.sh` failure handling in `apply.sh` so it also
sets `exit_code` when the boot step fails instead of only echoing a message. In
the script’s boot/update block, keep continuing execution after the failure, but
change the `|| echo "boot.sh failed, continuing..."` behavior to also record the
failure by assigning `exit_code=1` (or equivalent) alongside the existing
warning, so the final exit status reflects the failed boot step.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7ade0393-4765-47c5-b1e9-7dc5e0a7e0b8

📥 Commits

Reviewing files that changed from the base of the PR and between 87fda95 and ec762f2.

📒 Files selected for processing (1)

• apply.sh