Modernize dependencies, fix bugs, clean up tests, add CI#76
Merged
Conversation
Agents.md documents the architecture, source structure, build system, and conventions for AI-assisted development. REFRESH_PLAN.md outlines 13 prioritized improvements covering CI, dependency updates, bug fixes, module resolution, documentation, and feature requests. Generated with [Indent](https://indent.com) Co-Authored-By: Indent <noreply@indent.com>
- Update all dev dependencies: vite 5→6, vitest 1→3, react 18→19, nanostores 0.10→1.2, typescript 5.4→5.8, happy-dom 14→17, etc. - Fix duplicate setKey call in createMutatorStore error handler - Remove all console.log debug noise from factory.ts (was stripped in prod builds but polluted test output) - Replace fragile advance() test helper with vi.advanceTimersByTimeAsync, remove redundant multi-flush patterns throughout tests - Fix React 19 act() warning in integration tests - Add GitHub Actions CI workflow (full test on latest + matrix for 20/22) - Drop EOL Node 14/16 from engines field - Add tsconfig.vitest-temp.json to .gitignore Generated with [Indent](https://indent.com) Co-Authored-By: Indent <noreply@indent.com>
Generated with [Indent](https://indent.com) Co-Authored-By: Indent <noreply@indent.com>
- Fix typos: "Automaticallty" → "Automatically", "createMutationStore" → "createMutatorStore", "accept and argument" → "accept an argument", extra spaces, outdated size claim - Fix React Native module resolution (#67): add `import` and `default` conditions to `./react-native` exports, add `default` to main export - Document all store states (#75) with tables for fetcher and mutator stores covering every possible {loading, data, error} combination - Fix misleading usage example (#69): note that initial state is {loading: false} before subscription, update examples to check data first and handle error explicitly Generated with [Indent](https://indent.com) Co-Authored-By: Indent <noreply@indent.com>
…, size-limit 12, @types/node 25 Generated with [Indent](https://indent.com) Co-Authored-By: Indent <noreply@indent.com>
Generated with [Indent](https://indent.com) Co-Authored-By: Indent <noreply@indent.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dependencies & build
>=20.0.0)Bug fixes
setKeybug increateMutatorStore-- the error handler called bothsafeKeySet("error", ...)andstore.setKey("error", ...), bypassing the listener-count guard on unsubscribed storesimportanddefaultconditions to./react-nativesubpath export, adddefaultfallback to main exportTest improvements
console.logdebug logging fromfactory.ts-- these were stripped in production builds but flooded test output with hundreds of lines of noiseadvance()test helper to usevi.advanceTimersByTimeAsync()instead of the old hack (self-described as "I don't know what I'm doing") that manually flushed microtasks with repeatednew Promise(r => r())callsact()warning in the conditional render integration testDocumentation
{loading, data, error}combination and key behaviors{loading: false}, updated all code examples to checkdatafirst and handleerrorexplicitlyAgents.mddocumenting architecture, source structure, build system, and conventionsREFRESH_PLAN.mdwith prioritized improvement roadmapAddresses
@nanostores/query/react-native)Test plan
pnpm build)Generated with Indent - session link