Merged
Conversation
dcdenu4
approved these changes
Apr 13, 2026
Member
dcdenu4
left a comment
dcdenu4
left a comment
There was a problem hiding this comment.
Hey @davemfish, this looks good to me. Did you want to add a note in History.rst?
Comment on lines
+29
to
+33
| exclude: | ||
| - os: windows-latest | ||
| gdal-version: "3.11" | ||
| - os: macos-latest | ||
| gdal-version: "3.11" |
Member
There was a problem hiding this comment.
So we're only running the gdal version comparison on ubuntu. All else equal makes sense to conserve GHA runners.
| bool_name = 'Bool' | ||
| rat.CreateColumn(value_name, gdal.GFT_Integer, gdal.GFU_MinMax) | ||
| rat.CreateColumn(count_name, gdal.GFT_Integer, gdal.GFU_PixelCount) | ||
| if geometamaker.geometamaker.GDAL_VERSION < (3, 12, 0): |
Member
There was a problem hiding this comment.
Cool, convenient having the gdal version is handy
Member
|
@davemfish , going to merge and we can remember to add the HISTORY note during the release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guard against accessing attributes that are not available before GDAL 3.12.
When loading a RAT, we ask GDAL to get the type of each column and then read values using the method appropriate for that type. GDAL will only return types that it knows how to read. if it cannot determine the type it returns 'Integer'. So the only real bug here was accessing the constants for certain types in our utils.py module.