Fix: Missing ament_cmake_ros Dependency - #391
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original issue was: Jenkins build failed because
ament_cmake_roswas written in the CMakeLists.txt but not in the package.xml. So there are two options to fix that:ament_cmake_rosto package.xmlament_cmake_rostoament_cmakein CMakeLists.txtI decided to go for option 2 if the package is not using any feature of
ament_cmake_ros. That is the case for every package, so I replaced everyament_cmake_rosdependency withament_cmake. Problem was,ament_cmake_rossilently sets the build of a library to SHARED. So just replacing it changes the build process. Therefore I added the explicit SHARED keyword to all the libraries that didn't have it yet.Additionally, I did some consistency cleanups and removed obsolete things from the CMakeLists.