Skip to content

Complete the seatabler migration: queries and row writes #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexanderbates wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Complete the seatabler migration: queries and row writes #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b383e13
Delegate row writes to seatabler 0.2.0
alexanderbates Aug 23, 2026
98ac8c3
Delegate banctable_query to seatabler too
alexanderbates Aug 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Type: Package
Package: bancr
Title: R Client Access to the Brain And Nerve Cord (BANC) Dataset
Version: 0.3.7
Version: 0.3.8
Authors@R:
c(person(given = "Alexander",
family = "Bates",
Expand Down Expand Up @@ -40,7 +40,7 @@ Imports:
utils,
reticulate,
nat.ggplot,
seatabler (>= 0.2.0)
seatabler (>= 0.2.2)
Suggests:
testthat (>= 3.0.0),
readobj,
Expand Down
19 changes: 19 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,22 @@
# bancr 0.3.8 (development)

* `banctable_update_rows()` and `banctable_append_rows()` now delegate to
seatabler's `seatable_update_rows()` / `seatable_append_rows()`, which arrived
in seatabler 0.2.0. Names, signatures and defaults are unchanged, including
`append_allowed = FALSE` and `bigdata = FALSE`.
* Multiple-select columns are now detected from the table schema by seatabler
rather than being comma-split by hand in bancr, so a value containing a comma
is no longer silently broken into two options.
* New test covering the SeaTable Python path. bancr's suite previously passed
even when seatabler could not reach its Python dependencies, because nothing
exercised that path.
* `banctable_query()` now delegates to seatabler's `seatable_query()`, which
applies column types from the table schema as of seatabler 0.2.2. Reads are
unchanged: same columns in the same order, same values, and `status` stays
character. Five `number` count columns come back as `integer` rather than
`numeric`, which has no effect on the values.
* bancr now requires seatabler (>= 0.2.2) for that column coercion.

# bancr 0.3.7 (development)

* bancr now depends on [seatabler](https://github.com/flyconnectome/seatabler),
Expand Down
Loading
Loading