Return an error instead of panicking when encountering unsupported registers during unwind#56
Open
m-mueller678 wants to merge 3 commits into
Open
Return an error instead of panicking when encountering unsupported registers during unwind#56m-mueller678 wants to merge 3 commits into
m-mueller678 wants to merge 3 commits into
Conversation
This information is never used. Removing it is in preparation for faillible register access.
Owner
|
I suppose we might also be able to skip over any unsupported registers when unwinding (for phase 1 / stacktracing only, obviously we can't actually install contexts in such case). |
Author
|
Could that not break unwinding of future frames? I am not very familiar with unwinding, so I do not know how things could break when resuming with wrong register values |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #55.
I have changed
Frame::unwindto return a unit error type instead of a gimli error. The error information is currently discarded at all call sites ofFrame::unwind. I have considered two alternatives:UnsupportedRegistervariant of gimli's error type. This feels misleading, especially in the context of gimli's documentation:This fixes the problem I had encountered in #55. However, I am unsure of what testing procedures
unwinduses. I have only runcargo checkandcargo test. The test output looks the same as before my changes.